From e45c2bff1572b4e541d337d8f88ffd6c6f58c155 Mon Sep 17 00:00:00 2001 From: Ryan Ernst Date: Tue, 15 Apr 2025 11:40:27 -0700 Subject: [PATCH] Workaround max name limit imposed by Jackson 2.17 (#126806) In Jackson 2.15 a maximum string length of 50k characters was introduced. We worked around that by override the length to max int on all parsers created by xcontent. Jackson 2.17 introduced a similar limit on field names. This commit mimics the workaround for string length by overriding the max name length to be unlimited. relates #58952 --- docs/changelog/126806.yaml | 5 +++++ .../elasticsearch/xcontent/provider/XContentImplUtils.java | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 docs/changelog/126806.yaml diff --git a/docs/changelog/126806.yaml b/docs/changelog/126806.yaml new file mode 100644 index 0000000000000..cdc9d97d750cc --- /dev/null +++ b/docs/changelog/126806.yaml @@ -0,0 +1,5 @@ +pr: 126806 +summary: Workaround max name limit imposed by Jackson 2.17 +area: Infra/Core +type: bug +issues: [] diff --git a/libs/x-content/impl/src/main/java/org/elasticsearch/xcontent/provider/XContentImplUtils.java b/libs/x-content/impl/src/main/java/org/elasticsearch/xcontent/provider/XContentImplUtils.java index 558aafa34bac9..5433c9071d681 100644 --- a/libs/x-content/impl/src/main/java/org/elasticsearch/xcontent/provider/XContentImplUtils.java +++ b/libs/x-content/impl/src/main/java/org/elasticsearch/xcontent/provider/XContentImplUtils.java @@ -17,6 +17,10 @@ public class XContentImplUtils { public static > F configure(TSFBuilder builder) { // jackson 2.15 introduced a max string length. We have other limits in place to constrain max doc size, // so here we set to max value (2GiB) so as not to constrain further than those existing limits. - return builder.streamReadConstraints(StreamReadConstraints.builder().maxStringLength(Integer.MAX_VALUE).build()).build(); + // jackson 2.16 further introduced a max name length, which we also relax here temporarily. + // see https://github.com/elastic/elasticsearch/issues/58952 + return builder.streamReadConstraints( + StreamReadConstraints.builder().maxStringLength(Integer.MAX_VALUE).maxNameLength(Integer.MAX_VALUE).build() + ).build(); } }