-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Entitlements] Add missing outbound_network entitlement to x-pack-core #126992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ldematte
merged 7 commits into
elastic:main
from
ldematte:entitlements/fix-xpack-core-policy
Apr 18, 2025
Merged
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6737901
fix entitlement policy for x-pack-core
ldematte 9ca3bcc
Update docs/changelog/126992.yaml
ldematte a5b59fc
changelog
ldematte 11f8742
Update docs/changelog/126992.yaml
ldematte f2b9029
comment
ldematte 942d122
Merge remote-tracking branch 'upstream/main' into entitlements/fix-xp…
ldematte c5e3c1c
Merge branch 'entitlements/fix-xpack-core-policy' of github.com:ldema…
ldematte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| pr: 126992 | ||
| summary: "Add missing `outbound_network` entitlement to x-pack-core" | ||
| area: Infra/Core | ||
| type: bug | ||
| issues: [] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How did you determine this one was necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not, I erred on the safe side. I think this might be not needed, but as we have 0 test coverage (evidently) I have no way to tell.
Maybe I can add a comment along those lines, that if/when we will have better test coverage we can remove that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the comment seems like a good idea, though I suppose anyone looking for the origin of that line will land on this PR and see this very conversation.