Correctly handle non-integers in nested paths in the remove processor #127006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't throw, then the index wouldn't have been initialized, so now it's declared as being -1 -- note that this means that in the event of a non-integer it'll fall through to the next block with `if (index < 0` and that that one also won't throw. This seemed simpler to me than adding in an early return.
joegallo
added
>bug
:Data Management/Ingest Node
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @joegallo, I've created a changelog YAML for you. |
|
@parkertimmins after you've finished reviewing this on its own terms, but before you add a ✅, let's step through the |
chrisberkhout
approved these changes
Apr 17, 2025
|
Related to elastic/integrations#13455 and elastic/integrations#13294 |
💚 Backport successful
|
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Apr 18, 2025
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 18, 2025
5 tasks
This was referenced May 7, 2025
This was referenced May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that was introduced by #125232.
During path traversal, if we find a non-integer path for the next access inside a list, then that doesn't necessarily mean we must throw an exception -- rather, we should only throw an exception on a non-integer if ignoreMissing is false. That is, we should treat accessing the
"foo"index inside a list as just another missing path (for example).See also #126417 which is similar to this, but not the same. 😬