Skip to content

[9.0] Use explicit newline with keystore stdin test (#127094) #127130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

[9.0] Use explicit newline with keystore stdin test (#127094) #127130

merged 1 commit into from
Apr 21, 2025

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Apr 21, 2025

Backports the following commits to 9.0:

@rjernst
Use explicit newline with keystore stdin test (elastic#127094)
2522a34 
The add string keystore command accepts input on stdin. In this case,
the terminal is responsible for separating input by newlines that are
system dependent. The mock terminal normally adds the system dependent
newline. However, we also have tests that ensure both unix and windows
style newlines are tested explicitly. This commit fixes the windows
style carriage returns to explicitly contain a newline.

closes elastic#127089
@rjernst rjernst added :Core/Infra/CLI CLI utilities, scripts, and infrastructure >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Core/Infra Meta label for core/infra team labels Apr 21, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Apr 21, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit d92625e into elastic:9.0 Apr 21, 2025
16 checks passed
@rjernst rjernst deleted the backport/9.0/pr-127094 branch April 21, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Core/Infra/CLI CLI utilities, scripts, and infrastructure Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v9.0.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rjernst @elasticsearchmachine