New per-project only settings can be defined and used by components #127280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-ivanov-es
added
:Core/Infra/Settings
elasticsearchmachine
added
the
serverless-linked
alexey-ivanov-es
added
v9.1.0
and removed
serverless-linked
Collaborator
|
Hi @alexey-ivanov-es, I've created a changelog YAML for you. |
alexey-ivanov-es
added
the
serverless-linked
server/src/main/java/org/elasticsearch/common/settings/SettingsUpdater.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mark-vieira
approved these changes
Apr 24, 2025
Contributor
mark-vieira
left a comment
mark-vieira
left a comment
There was a problem hiding this comment.
One minor comment, otherwise LGTM.
server/src/main/java/org/elasticsearch/common/settings/BaseSettingsUpdater.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces Settings to
ProjectMetadataand adds project scope support forSetting.For now, project-scoped settings are independent from cluster settings and do not fall back to cluster-level settings.
Also, setting update consumers do not yet work correctly for project-scoped settings. These issues will be addressed separately in future PRs.
Closes: ES-10594