Using DataStream::getEffectiveSettings #127282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
:Data Management/Data streams
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
lukewhiting
approved these changes
Apr 25, 2025
Contributor
lukewhiting
left a comment
lukewhiting
left a comment
There was a problem hiding this comment.
Change looks good to me 👍🏻
This was referenced Apr 25, 2025
joegallo
pushed a commit
that referenced
this pull request
Jun 10, 2025
joegallo
pushed a commit
that referenced
this pull request
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #126947, by using the DataStream::getEffectiveSettings and DataStream::getEffectiveIndexTemplate methods introduced in that PR.
As of this PR, no externally-visible behavior is different. Rollover will now use the effective settings from the data stream, but since the settings actually stored on the data stream area always empty, the result is that the template settings continue to be used. Similarly, the settings used in the GetDataStreamAction will be the effective settings but will appear unchanged since the data stream settings are always empty.
A follow-up PR will introduce a transport action to set the data stream's settings.