Cleanup needlessly holding Exceptions in the can_match phase #127495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions can be quite expensive heap-wise and we don't use them here any longer, not even for logging -> replace atomic array with a set of shard indices and dry up the logic a tiny bit as a result as well.
original-brownbear
added
>non-issue
:Search Foundations/Search
elasticsearchmachine
added
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
drempapis
approved these changes
Apr 29, 2025
Contributor
drempapis
left a comment
drempapis
left a comment
There was a problem hiding this comment.
LGTM! The code looks cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exceptions can be quite expensive heap-wise and we don't use them here any longer, not even for logging -> replace atomic array with a set of shard indices and dry up the logic a tiny bit as a result as well.
We could also adjust the response class to not even have the exception but with #127471 inbound, the actual transport responses will shortly turn into a BwC only thing anyway.