Skip to content

[Failure Store] Remove IndicesPermissions#test(IndexAbstraction) method #127513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

[Failure Store] Remove IndicesPermissions#test(IndexAbstraction) method #127513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7fa407b
[Failure Store] Remove IndicesPermissions#test(IndexAbstraction) method
slobodanadamovic Apr 29, 2025
3982010
[CI] Auto commit changes from spotless
Apr 29, 2025
f0a1703
Merge branch 'main' into sa-failure-store-cleanup-def-method
slobodanadamovic Apr 29, 2025
a6f0a6e
fix imports
slobodanadamovic Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions ...c/main/java/org/elasticsearch/xpack/core/security/authz/permission/IndicesPermission.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,11 +232,6 @@ public final IsResourceAuthorizedPredicate and(IsResourceAuthorizedPredicate oth
);
}

// TODO remove me (this has >700 usages in tests which would make for a horrible diff; will remove this once the main PR is merged)
public boolean test(IndexAbstraction indexAbstraction) {
return test(indexAbstraction.getName(), indexAbstraction, IndexComponentSelector.DATA);
}

/**
* Verifies if access is authorized to the given {@param indexAbstraction} resource.
* The resource must exist. Otherwise, use the {@link #test(String, IndexAbstraction, IndexComponentSelector)} method.
Expand Down
Loading