From 6baebf5320274ac766c1e2f1783ab4bd6067d53a Mon Sep 17 00:00:00 2001 From: Jeremy Dahlgren Date: Tue, 29 Apr 2025 17:23:31 -0400 Subject: [PATCH 1/3] Adjust ForkJoinPool prefix in HdfsClientThreadLeakFilter Changes "ForkJoinPool-" to "ForkJoinPool." in the Thread getName().startsWith() checks in HdfsClientThreadLeakFilter. This resolves the "There are still zombie threads that couldn't be terminated" errors in the Hdfs IT tests. Closes #127290 Closes #127289 Closes #127288 Closes #127287 --- .../test/fixtures/hdfs/HdfsClientThreadLeakFilter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java b/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java index 81d17841f042a..6036da99b38e5 100644 --- a/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java +++ b/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java @@ -35,6 +35,6 @@ public boolean reject(Thread t) { || t.getName().startsWith("SSL Certificates Store Monitor") // hadoop 3 brings that in || t.getName().startsWith("GcTimeMonitor") // hadoop 3 || t.getName().startsWith("Command processor") // hadoop 3 - || t.getName().startsWith("ForkJoinPool-"); // hadoop 3 + || t.getName().startsWith("ForkJoinPool."); // hadoop 3 } } From d8ed34b94de555e3ce6c1f1d387ba8720cf95fea Mon Sep 17 00:00:00 2001 From: Jeremy Dahlgren Date: Tue, 29 Apr 2025 18:31:19 -0400 Subject: [PATCH 2/3] Filter by ForkJoinPool --- .../test/fixtures/hdfs/HdfsClientThreadLeakFilter.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java b/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java index 6036da99b38e5..7360f146e183e 100644 --- a/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java +++ b/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java @@ -35,6 +35,6 @@ public boolean reject(Thread t) { || t.getName().startsWith("SSL Certificates Store Monitor") // hadoop 3 brings that in || t.getName().startsWith("GcTimeMonitor") // hadoop 3 || t.getName().startsWith("Command processor") // hadoop 3 - || t.getName().startsWith("ForkJoinPool."); // hadoop 3 + || t.getName().startsWith("ForkJoinPool"); // hadoop 3 } } From 164c33c855a5cc255c9365f086a782f2f49062b4 Mon Sep 17 00:00:00 2001 From: Jeremy Dahlgren Date: Wed, 30 Apr 2025 07:29:51 -0400 Subject: [PATCH 3/3] Use ForkJoinPool.commonPool-worker- for new prefix addition --- .../test/fixtures/hdfs/HdfsClientThreadLeakFilter.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java b/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java index 7360f146e183e..0dc6b23b85406 100644 --- a/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java +++ b/test/fixtures/hdfs-fixture/src/main/java/org/elasticsearch/test/fixtures/hdfs/HdfsClientThreadLeakFilter.java @@ -35,6 +35,7 @@ public boolean reject(Thread t) { || t.getName().startsWith("SSL Certificates Store Monitor") // hadoop 3 brings that in || t.getName().startsWith("GcTimeMonitor") // hadoop 3 || t.getName().startsWith("Command processor") // hadoop 3 - || t.getName().startsWith("ForkJoinPool"); // hadoop 3 + || t.getName().startsWith("ForkJoinPool-") // hadoop 3 + || t.getName().startsWith("ForkJoinPool.commonPool-worker-"); // hadoop 3 } }