Skip to content

Mark semantic text inference_id param as optional #127586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

Mark semantic text inference_id param as optional #127586

merged 1 commit into from
Apr 30, 2025

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Apr 30, 2025

No description provided.

@Mikep86 Mikep86 added >docs General docs changes auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.0.1 v9.1.0 labels Apr 30, 2025
@Mikep86 Mikep86 requested a review from kderusso April 30, 2025 20:54
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

kderusso
kderusso approved these changes Apr 30, 2025
View reviewed changes
Copy link
Member

@kderusso kderusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - do we need a followup for 8.19?

@Mikep86
Copy link
Contributor Author

Mikep86 commented Apr 30, 2025

@kderusso Yep, was working on that in the background: #127587

@Mikep86 Mikep86 merged commit 9f8c9c9 into elastic:main Apr 30, 2025
6 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 9.0 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 127586

@Mikep86
Copy link
Contributor Author

Mikep86 commented Apr 30, 2025

💚 All backports created successfully

Status Branch Result
✅ 9.0

Questions ?

Please refer to the Backport tool documentation

@Mikep86 Mikep86 mentioned this pull request Apr 30, 2025
Merged
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Apr 30, 2025
@Mikep86
Mark semantic text inference_id param as optional (elastic#127586)
d5ae4fb 
(cherry picked from commit 9f8c9c9)

# Conflicts:
#	docs/reference/elasticsearch/mapping-reference/semantic-text.md
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2025
@Mikep86
Mark semantic text inference_id param as optional (#127586) (#127588)
fa3bebc 
(cherry picked from commit 9f8c9c9)

# Conflicts:
#	docs/reference/elasticsearch/mapping-reference/semantic-text.md
@shainaraskas shainaraskas mentioned this pull request Jul 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kderusso kderusso kderusso approved these changes

@Samiul-TheSoccerFan Samiul-TheSoccerFan Samiul-TheSoccerFan approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged >docs General docs changes :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v9.0.2 v9.1.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mikep86 @elasticsearchmachine @kderusso @Samiul-TheSoccerFan