Skip to content

Conversation

@thecoop
Copy link
Member

@thecoop thecoop commented May 1, 2025

StandardIOBehaviorHint is a hint to HybridDirectory that no specific IO behavior is expected nor should be inferred

@thecoop thecoop added :Search Relevance/Search Catch all for Search Relevance v9.1.0 labels May 1, 2025
@thecoop thecoop requested a review from ChrisHegarty May 1, 2025 15:37
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label May 1, 2025
* A hint that no special behavior should be set on open files
*/
public enum StandardIOBehaviorHint implements IOContext.FileOpenHint {
INSTANCE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have an ESFileOpenHint or something, where we can gather several open hints ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could do, but there can only be one hint of each type in an IOContext...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always add that later if it's useful

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop merged commit 5f54072 into elastic:lucene_snapshot May 6, 2025
16 checks passed
@thecoop thecoop deleted the standard-io-hint branch May 6, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>refactoring :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants