Fix IndexTemplateRegistryRolloverIT
#127695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My theory of why this test failed is that when we waited for the data stream to be marked for rollover, that condition was met on one of the nodes, causing us to index the documents to trigger the rollover, but the master node did not fully process the mark-for-rollover cluster state, resulting in the documents ending up in the first backing index. Therefore, we use `awaitClusterState` to wait for the data stream to be marked for rollover, which waits on the master node by default. Fixes elastic#127692
nielsbauman
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
lukewhiting
approved these changes
May 6, 2025
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
My theory of why this test failed is that when we waited for the data stream to be marked for rollover, that condition was met on one of the nodes, causing us to index the documents to trigger the rollover, but the master node did not fully process the mark-for-rollover cluster state, resulting in the documents ending up in the first backing index. Therefore, we use `awaitClusterState` to wait for the data stream to be marked for rollover, which waits on the master node by default. Fixes elastic#127692
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
My theory of why this test failed is that when we waited for the data stream to be marked for rollover, that condition was met on one of the nodes, causing us to index the documents to trigger the rollover, but the master node did not fully process the mark-for-rollover cluster state, resulting in the documents ending up in the first backing index. Therefore, we use `awaitClusterState` to wait for the data stream to be marked for rollover, which waits on the master node by default. Fixes elastic#127692
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My theory of why this test failed is that when we waited for the data stream to be marked for rollover, that condition was met on one of the nodes, causing us to index the documents to trigger the rollover, but the master node did not fully process the mark-for-rollover cluster state, resulting in the documents ending up in the first backing index.
Therefore, we use
awaitClusterStateto wait for the data stream to be marked for rollover, which waits on the master node by default.Fixes #127692
Relates #122852