Skip to content

Increase timeout for index migration in FullClusterRestartSystemIndexCompatibilityIT #127710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 5, 2025
Merged

Increase timeout for index migration in FullClusterRestartSystemIndexCompatibilityIT #127710

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0dede0
Add logging to FullClusterRestartSystemIndexCompatibilityIT
cbuescher May 5, 2025
2c3bf44
Increase timeout, migration might be occasionally slow
cbuescher May 5, 2025
26ba278
Merge branch 'main' into ci-127245-FullClusterRestartSystemIndexCompa…
cbuescher May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 29 additions & 13 deletions ...aRestTest/java/org/elasticsearch/lucene/FullClusterRestartSystemIndexCompatibilityIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

package org.elasticsearch.lucene;

import org.apache.http.util.EntityUtils;
import org.elasticsearch.client.Request;
import org.elasticsearch.client.RequestOptions;
import org.elasticsearch.client.Response;
Expand All @@ -17,6 +18,7 @@
import org.elasticsearch.cluster.metadata.IndexMetadata;
import org.elasticsearch.common.settings.Settings;
import org.elasticsearch.test.cluster.util.Version;
import org.elasticsearch.test.junit.annotations.TestIssueLogging;
import org.elasticsearch.test.rest.ObjectPath;

import java.io.IOException;
Expand All @@ -43,6 +45,10 @@ public FullClusterRestartSystemIndexCompatibilityIT(Version version) {
* 2. After update to N-1 (latest) perform a system index migration step, also write block the index
* 3. on N, check that async search results are still retrievable and we can write to the system index
*/
@TestIssueLogging(
value = "org.elasticsearch.lucene.FullClusterRestartSystemIndexCompatibilityIT:DEBUG",
issueUrl = "https://github.com/elastic/elasticsearch/issues/127245"
)
public void testAsyncSearchIndexMigration() throws Exception {
final String index = suffix("index");
final String asyncSearchIndex = ".async-search";
Expand Down Expand Up @@ -83,19 +89,29 @@ public void testAsyncSearchIndexMigration() throws Exception {
ObjectPath.createFromResponse(client().performRequest(migrateRequest)).evaluate("features.0.feature_name"),
equalTo("async_search")
);
assertBusy(() -> {
Request checkMigrateProgress = new Request("GET", "/_migration/system_features");
Response resp = null;
try {
assertFalse(
ObjectPath.createFromResponse(client().performRequest(checkMigrateProgress))
.evaluate("migration_status")
.equals("IN_PROGRESS")
);
} catch (IOException e) {
throw new AssertionError("System feature migration failed", e);
}
});

logger.debug("--> starting system index migration");
Request checkMigrateProgress = new Request("GET", "/_migration/system_features");
try {
assertBusy(() -> {
Response resp = null;
try {
assertFalse(
ObjectPath.createFromResponse(client().performRequest(checkMigrateProgress))
.evaluate("migration_status")
.equals("IN_PROGRESS")
);
} catch (IOException e) {
throw new AssertionError("System feature migration failed", e);
}
});
} catch (AssertionError e) {
logger.debug(
"--> system index migration not finished yet, response: {}",
EntityUtils.toString(client().performRequest(checkMigrateProgress).getEntity())
);
throw e;
}

// check search results from n-2 search are still readable
assertAsyncSearchHitCount(async_search_ids.get("n-2_id"), numDocs);
Expand Down