From ec237b40862e9a0ac588b03ad97efc89d630cba8 Mon Sep 17 00:00:00 2001 From: Jonathan Buttner Date: Wed, 7 May 2025 16:09:08 -0400 Subject: [PATCH 1/3] Fixing rerank location --- .../services/googlevertexai/GoogleVertexAiService.java | 2 +- .../services/googlevertexai/GoogleVertexAiServiceTests.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiService.java b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiService.java index e966ebc8d9e9b..b849ed2e5cc9c 100644 --- a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiService.java +++ b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiService.java @@ -348,7 +348,7 @@ public static InferenceServiceConfiguration get() { configurationMap.put( LOCATION, - new SettingsConfiguration.Builder(supportedTaskTypes).setDescription( + new SettingsConfiguration.Builder(EnumSet.of(TaskType.TEXT_EMBEDDING)).setDescription( "Please provide the GCP region where the Vertex AI API(s) is enabled. " + "For more information, refer to the {geminiVertexAIDocs}." ) diff --git a/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiServiceTests.java b/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiServiceTests.java index 932dfc21e9396..8ea1c12ea9e4a 100644 --- a/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiServiceTests.java +++ b/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiServiceTests.java @@ -898,7 +898,7 @@ public void testGetConfiguration() throws Exception { "sensitive": false, "updatable": false, "type": "str", - "supported_task_types": ["text_embedding", "rerank"] + "supported_task_types": ["text_embedding"] }, "rate_limit.requests_per_minute": { "description": "Minimize the number of rate limit errors.", From 022b4af6d9aa1f106fb0ee454278fccd19db13d7 Mon Sep 17 00:00:00 2001 From: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com> Date: Wed, 7 May 2025 16:16:25 -0400 Subject: [PATCH 2/3] Update docs/changelog/127856.yaml --- docs/changelog/127856.yaml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 docs/changelog/127856.yaml diff --git a/docs/changelog/127856.yaml b/docs/changelog/127856.yaml new file mode 100644 index 0000000000000..a5dc9a92fdbbb --- /dev/null +++ b/docs/changelog/127856.yaml @@ -0,0 +1,5 @@ +pr: 127856 +summary: Fixing Google Vertex AI Rerank task type location field +area: Machine Learning +type: bug +issues: [] From a1b278580c0cde5c1bc0b220f58c0b866edca9c8 Mon Sep 17 00:00:00 2001 From: Jonathan Buttner Date: Wed, 7 May 2025 16:38:21 -0400 Subject: [PATCH 3/3] Refactor changelog --- docs/changelog/127856.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/changelog/127856.yaml b/docs/changelog/127856.yaml index a5dc9a92fdbbb..bdd7657a58e73 100644 --- a/docs/changelog/127856.yaml +++ b/docs/changelog/127856.yaml @@ -1,5 +1,5 @@ pr: 127856 -summary: Fixing Google Vertex AI Rerank task type location field +summary: Fix services API Google Vertex AI Rerank location field requirement area: Machine Learning type: bug issues: []