From cb2f9e6dee88dc135aa555d32c588ab232dfb0bb Mon Sep 17 00:00:00 2001 From: Jonathan Buttner <56361221+jonathan-buttner@users.noreply.github.com> Date: Wed, 7 May 2025 17:47:38 -0400 Subject: [PATCH] [ML] Fixing Google Vertex AI Rerank task type location field (#127856) * Fixing rerank location * Update docs/changelog/127856.yaml * Refactor changelog --- docs/changelog/127856.yaml | 5 +++++ .../services/googlevertexai/GoogleVertexAiService.java | 2 +- .../services/googlevertexai/GoogleVertexAiServiceTests.java | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 docs/changelog/127856.yaml diff --git a/docs/changelog/127856.yaml b/docs/changelog/127856.yaml new file mode 100644 index 0000000000000..bdd7657a58e73 --- /dev/null +++ b/docs/changelog/127856.yaml @@ -0,0 +1,5 @@ +pr: 127856 +summary: Fix services API Google Vertex AI Rerank location field requirement +area: Machine Learning +type: bug +issues: [] diff --git a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiService.java b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiService.java index 3e921f669e864..0c696bbb190f6 100644 --- a/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiService.java +++ b/x-pack/plugin/inference/src/main/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiService.java @@ -342,7 +342,7 @@ public static InferenceServiceConfiguration get() { configurationMap.put( LOCATION, - new SettingsConfiguration.Builder(supportedTaskTypes).setDescription( + new SettingsConfiguration.Builder(EnumSet.of(TaskType.TEXT_EMBEDDING)).setDescription( "Please provide the GCP region where the Vertex AI API(s) is enabled. " + "For more information, refer to the {geminiVertexAIDocs}." ) diff --git a/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiServiceTests.java b/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiServiceTests.java index 932dfc21e9396..8ea1c12ea9e4a 100644 --- a/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiServiceTests.java +++ b/x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/services/googlevertexai/GoogleVertexAiServiceTests.java @@ -898,7 +898,7 @@ public void testGetConfiguration() throws Exception { "sensitive": false, "updatable": false, "type": "str", - "supported_task_types": ["text_embedding", "rerank"] + "supported_task_types": ["text_embedding"] }, "rate_limit.requests_per_minute": { "description": "Minimize the number of rate limit errors.",