Fix RemoteClusterSecurityFcActionAuthorizationIT testIndicesPrivilegesAreEnforcedForCcrRestoreSessionActions to wait for references to be cleared #127888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sAreEnforcedForCcrRestoreSessionActions to wait for references to be cleared (fixes elastic#127782)
mosche
added
:Core/Infra/Transport API
elasticsearchmachine
added
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
|
@original-brownbear could you give this a sanity check, this started to fail randomly with #127058. I suspect due to deserialisation happening on a separate thread pool, but honestly also didn't look to closely. |
|
btw, wondering why this was automatically tagged core/infra. Is it? |
mosche
added
>test
|
Hmm @mosche were you able to reproduce that this actually fixes the failure? I think we could have a race here indeed where we close on the thread that resolves the future (and after we resolve the future). Mainly asking to rule out any other issues :) |
original-brownbear
approved these changes
May 8, 2025
|
@elasticmachine update branch |
|
There are no new commits on the base branch. |
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
…sAreEnforcedForCcrRestoreSessionActions to wait for references to be cleared (fixes elastic#127782) (elastic#127888)
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
…sAreEnforcedForCcrRestoreSessionActions to wait for references to be cleared (fixes elastic#127782) (elastic#127888)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RemoteClusterSecurityFcActionAuthorizationIT testIndicesPrivilegesAreEnforcedForCcrRestoreSessionActions to wait for references to be cleared.
(fixes #127782)