Skip to content

Fix + unmute SampleTests #127959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
Merged

Fix + unmute SampleTests #127959

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7f9878
Fix + unmute SampleTests
jan-elastic May 9, 2025
07503c0
Merge branch 'main' into fix-sampletests
jan-elastic May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,12 +462,6 @@ tests:
- class: org.elasticsearch.indices.stats.IndexStatsIT
method: testThrottleStats
issue: https://github.com/elastic/elasticsearch/issues/126359
- class: org.elasticsearch.xpack.esql.expression.function.aggregate.SampleTests
method: testGroupingAggregate {TestCase=<long unicode KEYWORDs>}
issue: https://github.com/elastic/elasticsearch/issues/127950
- class: org.elasticsearch.xpack.esql.expression.function.aggregate.SampleTests
method: testGroupingAggregate {TestCase=<long unicode TEXTs>}
issue: https://github.com/elastic/elasticsearch/issues/127951
- class: org.elasticsearch.search.vectors.IVFKnnFloatVectorQueryTests
method: testRandomWithFilter
issue: https://github.com/elastic/elasticsearch/issues/127963
Expand Down
8 changes: 4 additions & 4 deletions ...src/test/java/org/elasticsearch/xpack/esql/expression/function/aggregate/SampleTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ public static Iterable<Object[]> parameters() {
MultiRowTestCaseSupplier.booleanCases(1, 1000),
MultiRowTestCaseSupplier.ipCases(1, 1000),
MultiRowTestCaseSupplier.versionCases(1, 1000),
MultiRowTestCaseSupplier.stringCases(1, 1000, DataType.KEYWORD),
MultiRowTestCaseSupplier.stringCases(1, 1000, DataType.TEXT),
MultiRowTestCaseSupplier.stringCases(1, 20, DataType.KEYWORD),
MultiRowTestCaseSupplier.stringCases(1, 20, DataType.TEXT),
Copy link
Contributor Author

@jan-elastic jan-elastic May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the same values as in ValuesTests now, so that should be safe.

MultiRowTestCaseSupplier.geoPointCases(1, 1000, MultiRowTestCaseSupplier.IncludingAltitude.NO),
MultiRowTestCaseSupplier.cartesianPointCases(1, 1000, MultiRowTestCaseSupplier.IncludingAltitude.NO),
MultiRowTestCaseSupplier.geoShapeCasesWithoutCircle(1, 100, MultiRowTestCaseSupplier.IncludingAltitude.NO),
MultiRowTestCaseSupplier.cartesianShapeCasesWithoutCircle(1, 100, MultiRowTestCaseSupplier.IncludingAltitude.NO)
MultiRowTestCaseSupplier.geoShapeCasesWithoutCircle(1, 20, MultiRowTestCaseSupplier.IncludingAltitude.NO),
MultiRowTestCaseSupplier.cartesianShapeCasesWithoutCircle(1, 20, MultiRowTestCaseSupplier.IncludingAltitude.NO)
)
.flatMap(List::stream)
.map(fieldCaseSupplier -> makeSupplier(fieldCaseSupplier, limitCaseSupplier))
Expand Down