ESQL: Unmute test and reuse blockFactory to avoid concurrently modifying the test factories list #128211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the test factories list
ivancea
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
May 21, 2025
…ing the test factories list (elastic#128211) Fixes elastic#128092 The error happens inside an ArrayList.add(), and it's a concurrency-related one. The stacktrace is quite explicative: ``` java.lang.ArrayIndexOutOfBoundsException: Index 34 out of bounds for length 33 at java.util.ArrayList.add(ArrayList.java:485) at org.elasticsearch.compute.test.ComputeTestCase.blockFactory(ComputeTestCase.java:62) at org.elasticsearch.compute.aggregation.GroupingAggregatorFunctionTestCase$4$1$1.addBlock(GroupingAggregatorFunctionTestCase.java:659) ``` We were creating new blockFactories() inside the aggregator, which was being called concurrently with different drivers. As `blockFactory()` adds it to a static ArrayList, it was sometimes throwing. The bug only affects tests. Potentially, all grouping aggregators tests.
ivancea
added a commit
to ivancea/elasticsearch
that referenced
this pull request
May 21, 2025
…ing the test factories list (elastic#128211) Fixes elastic#128092 The error happens inside an ArrayList.add(), and it's a concurrency-related one. The stacktrace is quite explicative: ``` java.lang.ArrayIndexOutOfBoundsException: Index 34 out of bounds for length 33 at java.util.ArrayList.add(ArrayList.java:485) at org.elasticsearch.compute.test.ComputeTestCase.blockFactory(ComputeTestCase.java:62) at org.elasticsearch.compute.aggregation.GroupingAggregatorFunctionTestCase$4$1$1.addBlock(GroupingAggregatorFunctionTestCase.java:659) ``` We were creating new blockFactories() inside the aggregator, which was being called concurrently with different drivers. As `blockFactory()` adds it to a static ArrayList, it was sometimes throwing. The bug only affects tests. Potentially, all grouping aggregators tests.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 21, 2025
…ing the test factories list (#128211) (#128243) Fixes #128092 The error happens inside an ArrayList.add(), and it's a concurrency-related one. The stacktrace is quite explicative: ``` java.lang.ArrayIndexOutOfBoundsException: Index 34 out of bounds for length 33 at java.util.ArrayList.add(ArrayList.java:485) at org.elasticsearch.compute.test.ComputeTestCase.blockFactory(ComputeTestCase.java:62) at org.elasticsearch.compute.aggregation.GroupingAggregatorFunctionTestCase$4$1$1.addBlock(GroupingAggregatorFunctionTestCase.java:659) ``` We were creating new blockFactories() inside the aggregator, which was being called concurrently with different drivers. As `blockFactory()` adds it to a static ArrayList, it was sometimes throwing. The bug only affects tests. Potentially, all grouping aggregators tests.
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 21, 2025
…ing the test factories list (#128211) (#128242) Fixes #128092 The error happens inside an ArrayList.add(), and it's a concurrency-related one. The stacktrace is quite explicative: ``` java.lang.ArrayIndexOutOfBoundsException: Index 34 out of bounds for length 33 at java.util.ArrayList.add(ArrayList.java:485) at org.elasticsearch.compute.test.ComputeTestCase.blockFactory(ComputeTestCase.java:62) at org.elasticsearch.compute.aggregation.GroupingAggregatorFunctionTestCase$4$1$1.addBlock(GroupingAggregatorFunctionTestCase.java:659) ``` We were creating new blockFactories() inside the aggregator, which was being called concurrently with different drivers. As `blockFactory()` adds it to a static ArrayList, it was sometimes throwing. The bug only affects tests. Potentially, all grouping aggregators tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128092
The error happens inside an ArrayList.add(), and it's a concurrency-related one.
The stacktrace is quite explicative:
We were creating new blockFactories() inside the aggregator, which was being called concurrently with different drivers. As
blockFactory()adds it to a static ArrayList, it was sometimes throwing.The bug only affects tests. Potentially, all grouping aggregators tests.
If it happened after a recent change, i don't know. It doesn't look like it to me; that code is some months old. But I changed the caller chain, so maybe there are other mutes somewhere that I couldn't find