Skip to content

ESQL: Unmute test and reuse blockFactory to avoid concurrently modifying the test factories list #128211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

ESQL: Unmute test and reuse blockFactory to avoid concurrently modifying the test factories list #128211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5430e27
ESQL: Unmute test and reuse blockFactory to avoid concurrently modify…
ivancea May 20, 2025
ee9464d
Merge branch 'main' into esql-unmute-array-index-percentile-test
ivancea May 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,9 +438,6 @@ tests:
- class: org.elasticsearch.xpack.esql.qa.multi_node.EsqlSpecIT
method: test {lookup-join.MvJoinKeyOnTheLookupIndex ASYNC}
issue: https://github.com/elastic/elasticsearch/issues/128030
- class: org.elasticsearch.compute.aggregation.PercentileIntGroupingAggregatorFunctionTests
method: testManyInitialManyPartialFinalRunner
issue: https://github.com/elastic/elasticsearch/issues/128092
- class: org.elasticsearch.packaging.test.DockerTests
method: test042KeystorePermissionsAreCorrect
issue: https://github.com/elastic/elasticsearch/issues/128018
Expand Down
2 changes: 1 addition & 1 deletion ...c/test/java/org/elasticsearch/compute/aggregation/GroupingAggregatorFunctionTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ public AddInput prepareProcessPage(SeenGroupIds ignoredSeenGroupIds, Page page)

private void addBlock(int positionOffset, IntBlock groupIds) {
for (int offset = 0; offset < groupIds.getPositionCount(); offset += emitChunkSize) {
try (IntBlock.Builder builder = blockFactory().newIntBlockBuilder(emitChunkSize)) {
try (IntBlock.Builder builder = driverContext.blockFactory().newIntBlockBuilder(emitChunkSize)) {
int endP = Math.min(groupIds.getPositionCount(), offset + emitChunkSize);
for (int p = offset; p < endP; p++) {
int start = groupIds.getFirstValueIndex(p);
Expand Down