Remove unnecessary knn param boxing and simplyfing somethings #128693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
benwtrent
added
the
auto-merge-without-approval
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 3, 2025
…c#128693) some refactoring I noticed recently that we can do. Now k is always provided we can remove boxing and this simplifies some logic. Additionally, modernizes and simplifies some tests. No behavior change in this PR.
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Jun 3, 2025
…c#128693) some refactoring I noticed recently that we can do. Now k is always provided we can remove boxing and this simplifies some logic. Additionally, modernizes and simplifies some tests. No behavior change in this PR.
Samiul-TheSoccerFan
pushed a commit
to Samiul-TheSoccerFan/elasticsearch
that referenced
this pull request
Jun 5, 2025
…c#128693) some refactoring I noticed recently that we can do. Now k is always provided we can remove boxing and this simplifies some logic. Additionally, modernizes and simplifies some tests. No behavior change in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some refactoring I noticed recently that we can do. Now k is always provided we can remove boxing and this simplifies some logic.
Additionally, modernizes and simplifies some tests. No behavior change in this PR.