From dfe9bc945cf17354094dbee80cb3ec2bd3f6d037 Mon Sep 17 00:00:00 2001 From: ChrisHegarty Date: Wed, 4 Jun 2025 14:07:21 +0100 Subject: [PATCH 1/2] re-enable direct io --- .../codec/vectors/es818/DirectIOLucene99FlatVectorsReader.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/server/src/main/java/org/elasticsearch/index/codec/vectors/es818/DirectIOLucene99FlatVectorsReader.java b/server/src/main/java/org/elasticsearch/index/codec/vectors/es818/DirectIOLucene99FlatVectorsReader.java index d1c107ebe15a9..c989ee9ce15d4 100644 --- a/server/src/main/java/org/elasticsearch/index/codec/vectors/es818/DirectIOLucene99FlatVectorsReader.java +++ b/server/src/main/java/org/elasticsearch/index/codec/vectors/es818/DirectIOLucene99FlatVectorsReader.java @@ -57,7 +57,7 @@ @SuppressForbidden(reason = "Copied from lucene") public class DirectIOLucene99FlatVectorsReader extends FlatVectorsReader implements OffHeapStats { - private static final boolean USE_DIRECT_IO = Boolean.parseBoolean(System.getProperty("vector.rescoring.directio", "false")); + private static final boolean USE_DIRECT_IO = Boolean.parseBoolean(System.getProperty("vector.rescoring.directio", "true")); private static final long SHALLOW_SIZE = RamUsageEstimator.shallowSizeOfInstance(DirectIOLucene99FlatVectorsReader.class); From 9b52ba14513dbf4bbebcc9c864ba75937d98ef6e Mon Sep 17 00:00:00 2001 From: ChrisHegarty Date: Wed, 11 Jun 2025 11:06:16 +0100 Subject: [PATCH 2/2] unmute --- muted-tests.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/muted-tests.yml b/muted-tests.yml index ed3971f523f39..c78dc50734fba 100644 --- a/muted-tests.yml +++ b/muted-tests.yml @@ -484,9 +484,6 @@ tests: - class: org.elasticsearch.index.codec.vectors.es818.ES818BinaryQuantizedVectorsFormatTests method: testSimpleOffHeapSizeFSDir issue: https://github.com/elastic/elasticsearch/issues/128800 -- class: org.elasticsearch.index.store.DirectIOIT - method: testDirectIOUsed - issue: https://github.com/elastic/elasticsearch/issues/128829 - class: org.elasticsearch.packaging.test.DockerTests method: test150MachineDependentHeap issue: https://github.com/elastic/elasticsearch/issues/128120