ES|QL: Fork - support GROK, CHANGE_POINT and COMPLETION in branches #129249
Conversation
ioanatia
added
>non-issue
:Analytics/ES|QL
ioanatia
requested review from
ChrisHegarty,
afoucret,
carlosdelest and
tteofili
| | changePointCommand | ||
| | completionCommand | ||
| | grokCommand | ||
| | {this.isDevVersion()}? inlinestatsCommand |
There was a problem hiding this comment.
we just extend the grammar to support these 4 commands.
what we miss are:
- some commands that are only available in snapshot that I am not sure when/if they will be available (like
RERANK) - DROP/KEEP/MV_EXPAND/RENAME which produce a parsing error when used inside fork branches, so we exclude them for now
There was a problem hiding this comment.
We discussed this and for now we don't need to support commands that are in snapshot.
So I am removing inlinestats
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/kibana-esql (ES|QL-ui) |
elasticsearchmachine
removed
the
Team:Search - Relevance
| Spanish | null | fork2 | ||
| ; | ||
|
|
||
| forkBranchWithDrop-Ignore |
There was a problem hiding this comment.
Should we remove the -Ignore tests? They don't seem to be able to pass even when commands are supported (the results don't look right).
There was a problem hiding this comment.
I'd like to keep them, because we would add them anyway when we fix the grammar in the next days.
|
the serverless checks failed, but it looked like it was a Buildkite fluke. |
ioanatia
changed the title
ioanatia
changed the title
4 participants
related: #126553
Changes the FORK command so that we support more commands in FORK branches.
We want to change the grammar so that we support all commands, but we get a weird error for some of them.
The only ones that are not commands available only in snapshot, that we don't support yet are DROP/MV_EXPAND/RENAME/KEEP.
What these have in common is that they use
qualifiedNamePatternsorqualifiedName.In the meantime for all the rest, we added CSV tests to make sure we actually support them.