Skip to content

Register match_phrase as a function not a snapshot function #129255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2025
Merged

Register match_phrase as a function not a snapshot function #129255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a688ac
Register match_phrase as a function not a snapshot function
kderusso Jun 11, 2025
c31ce12
Update usage
kderusso Jun 11, 2025
ea54b47
Merge branch 'main' into kderusso/esql-match-phrase-function-registry…
kderusso Jun 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/reference/query-languages/esql/kibana/definition/functions/match_phrase.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions .../src/main/java/org/elasticsearch/xpack/esql/expression/function/EsqlFunctionRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,7 +466,8 @@ private static FunctionDefinition[][] functions() {
def(Kql.class, uni(Kql::new), "kql"),
def(Match.class, tri(Match::new), "match"),
def(MultiMatch.class, MultiMatch::new, "multi_match"),
def(QueryString.class, bi(QueryString::new), "qstr") } };
def(QueryString.class, bi(QueryString::new), "qstr"),
def(MatchPhrase.class, tri(MatchPhrase::new), "match_phrase") } };

}

Expand All @@ -486,7 +487,6 @@ private static FunctionDefinition[][] snapshotFunctions() {
def(LastOverTime.class, LastOverTime::withUnresolvedTimestamp, "last_over_time"),
def(FirstOverTime.class, FirstOverTime::withUnresolvedTimestamp, "first_over_time"),
def(Term.class, bi(Term::new), "term"),
def(MatchPhrase.class, tri(MatchPhrase::new), "match_phrase"),
def(Knn.class, tri(Knn::new), "knn") } };
}

Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/60_usage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ setup:
- match: {esql.functions.coalesce: $functions_coalesce}
- gt: {esql.functions.categorize: $functions_categorize}
# Testing for the entire function set isn't feasible, so we just check that we return the correct count as an approximation.
- length: {esql.functions: 157} # check the "sister" test below for a likely update to the same esql.functions length check
- length: {esql.functions: 158} # check the "sister" test below for a likely update to the same esql.functions length check
Copy link
Member

@carlosdelest carlosdelest Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to update the number of functions on the non-snapshot version?

Copy link
Member Author

@kderusso kderusso Jun 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I think this is right now, based on the changes to the original PR?

Copy link
Member

@carlosdelest carlosdelest Jun 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that's right 👍 Tests will tell...


---
"Basic ESQL usage output (telemetry) non-snapshot version":
Expand Down
Loading