Integrate project global blocks into existing checks for cluster blocks (Part 2) #129570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pxsalehi
added
>non-issue
:Distributed Coordination/Distributed
elasticsearchmachine
added
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
ywangd
approved these changes
Jun 18, 2025
Comment on lines
125
to
129
| @FixForMultiProject( | ||
| description = "Many actions extend TransportSingleShardAction, consider checking for project global blocks when applicable" | ||
| ) | ||
| protected static ClusterBlockException checkGlobalBlock(ProjectState state) { | ||
| return state.blocks().globalBlockedException(ClusterBlockLevel.READ); |
There was a problem hiding this comment.
Since this action always involves a shard which always belongs to a project, I think we can add projectResolver.getProjectId() here without having to defer this as future work? The checkRequestBlock method below already checks project indices blocks. Or maybe I am missing something?
kderusso
pushed a commit
to kderusso/elasticsearch
that referenced
this pull request
Jun 23, 2025
…ks (Part 2) (elastic#129570) Relates elastic#129467 Resolves ES-11209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went through the second half of callers to
globalBlockedExceptionand updated the obvious cases.Relates #129467
Resolves ES-11209