-
Notifications
You must be signed in to change notification settings - Fork 25.6k
JDKVectorLibrary: update low-level bounds checks and add benchmark #130216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
benwtrent
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥹 its beautiful
|
@ChrisHegarty I get |
|
@ChrisHegarty well, now I don't get that exception. Maybe I didn't apply your changes correctly locally. Testing some more :) |
check that you have the change from |
|
OK, yes! that worked, but I am running into other things (likely other weirdness) when trying to access native methods directly. Adding this to my benchmark (to access native method handle directly): results in So, likely I need to do some initialization step, or adjust my JVM version? |
|
@ChrisHegarty I was able to figure it out. Apparently the native libraries didn't get built right locally, rebuilt and its all good :) |
…lastic#130216) This commit updates the low-level bounds checks in JDKVectorLibrary and add benchmark, so that we can more easily bench the low-level operations. Note: I added the mr-jar gradle plugin to the benchmarks so that we can compile with preview features in Java 21, namely MemorySegment.
This commit updates the low-level bounds checks in JDKVectorLibrary and add benchmark, so that we can more easily bench the low-level operations.
Note: I added the mr-jar gradle plugin to the benchmarks so that we can compile with preview features in Java 21, namely MemorySegment.