ESQL: TopNOperator, release Row on failure #130330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GalLalouche
added
>bug
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @GalLalouche, I've created a changelog YAML for you. |
GalLalouche
commented
Jun 30, 2025
| p = 0; | ||
| } | ||
|
|
||
| Row row = list.get(i); |
Contributor
Author
There was a problem hiding this comment.
This line was basically moved to the try-with-resource clause. Everything else is indentation.
alex-spies
approved these changes
Jun 30, 2025
idegtiarenko
approved these changes
Jun 30, 2025
ivancea
approved these changes
Jun 30, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Jun 30, 2025
Handles the case where the Row was released on failure, by moving the declaration to a try-with-resource clause. Resolves elastic#130215, elastic#130222, elastic#130270.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Jun 30, 2025
Handles the case where the Row was released on failure, by moving the declaration to a try-with-resource clause. Resolves elastic#130215, elastic#130222, elastic#130270.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 30, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
Handles the case where the Row was released on failure, by moving the declaration to a try-with-resource clause. Resolves elastic#130215, elastic#130222, elastic#130270.
GalLalouche
added a commit
to GalLalouche/elasticsearch
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #130215, #130222, #130270.