Skip to content

[9.1] ESQL: TopNOperator, release Row on failure (Manual backport) #130349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2025
Merged

[9.1] ESQL: TopNOperator, release Row on failure (Manual backport) #130349

merged 1 commit into from
Jun 30, 2025

Conversation

@GalLalouche
Copy link
Contributor

@GalLalouche GalLalouche commented Jun 30, 2025

Manually backporting #130330.

@GalLalouche GalLalouche added >bug backport Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Analytics/ES|QL AKA ESQL labels Jun 30, 2025
@GalLalouche
ESQL: TopNOperator, release Row on failure (elastic#130330)
c861000 
Handles the case where the Row was released on failure, by moving the declaration to a try-with-resource clause.

Resolves elastic#130215, elastic#130222, elastic#130270.
@GalLalouche GalLalouche enabled auto-merge (squash) June 30, 2025 18:43
@GalLalouche GalLalouche disabled auto-merge June 30, 2025 18:43
@GalLalouche GalLalouche enabled auto-merge (squash) June 30, 2025 18:44
@elasticsearchmachine elasticsearchmachine merged commit e9416df into elastic:9.1 Jun 30, 2025
32 checks passed
@GalLalouche GalLalouche deleted the 91/topnfix branch June 30, 2025 19:41
GalLalouche added a commit to GalLalouche/elasticsearch that referenced this pull request Jul 7, 2025
@GalLalouche
ESQL: Unmute tests fixed by elastic#130349
c4e9265
This was referenced Jul 7, 2025
Closed
Merged
GalLalouche added a commit that referenced this pull request Jul 7, 2025
@GalLalouche
ESQL: Unmute tests fixed by #130349 (#130734)
43d8d59 
Unmute tests which were fixed by #130349.

Resolves #130122.
Resolves #130270.
Resolves #130426.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.1.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GalLalouche @elasticsearchmachine