ES|QL: Add FUSE as a copy of RRF #130434
Merged
ES|QL: Add FUSE as a copy of RRF #130434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>non-issue
ES|QL-ui
elasticsearchmachine
added
the
Team:Search Relevance
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Pinging @elastic/kibana-esql (ES|QL-ui) |
elasticsearchmachine
removed
the
Team:Search - Relevance
ioanatia
commented
Jul 2, 2025
| @@ -0,0 +1,136 @@ | |||
| // | |||
| // CSV spec for FUSE command | |||
There was a problem hiding this comment.
this is pretty much a copy of the RRF csv tests
tteofili
approved these changes
Jul 2, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #123389
We know we will not have a RRF command, but rather another command called FUSE that will handle both reciprocal rank fusion and linear combination.
We have a very high degree of confidence that
FUSEwith no options will apply reciprocal rank fusion by default.We also know that unlike the
RRFcommand,FUSEwill not order the results.I am adding
FUSEas pretty much a copy ofRRF. It's a copy for now and not a replacement.Kibana already has autocomplete for the
RRFcommand.I checked with @stratoula that removing RRF in ES will cause failures in Kibana once we try to update the grammar files there.
Which is why for a brief moment we will have both FUSE and RRF.
Once we update the grammar files in Kibana, we can replace the autocomplete that we had for
RRFto just be an initial version of the autocomplete forFUSE. After that we can just remove the RRF command in ES.It was either going on this route of making
FUSEa copy ofRRFor reverting the autocomplete we have in Kibana forRRF.I think this way is less intrusive.