Don't check TSDB end time in YAML test #130761
Conversation
The end time of a TSDB data stream is updated by `UpdateTimeSeriesRangeService` every 5 minutes. This means that every once in a while the test fails if UpdateTimeSeriesRangeService happens to have run during the test. This PR gets rid of this check. It's a bit odd that this failure hasn't shown up before (i.e. outside of the multi-project test suite), but I suspect it's related to the race condition we're seeing here - the MP test suite is likely a bit slower, making it slightly more likely to occur, perhaps. Resolves elastic#124575
nielsbauman
added
>test
elasticsearchmachine
added
v9.2.0
Team:Data Management
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
left a comment
masseyke
left a comment
There was a problem hiding this comment.
Seems like a reasonable theory to me. I'm also concerned about why it wasn't doing this before. Did you accidentally fix UpdateTimeSeriesRangeService while adding multiproject support?
|
I just realized that the cause is probably that we run these tests with a slightly different setup in the MP test suite. The data streams module has its own dedicated YAML test suite, but we're simply throwing it on a heap of YAML tests when we run the MP YAML test suite (with a slightly different cluster configuration). That will change in the future (every test suite will run in MP mode on its own, instead of running one big MP suite). I still think it's fine to merge this fix (instead of just muting the test in MP temporarily), as it still feels like a race condition to me. |
|
This fix makes sense to me too. |
4 participants
The end time of a TSDB data stream is updated by
UpdateTimeSeriesRangeServiceevery 5 minutes. This means that every once in a while the test fails if UpdateTimeSeriesRangeService happens to have run during the test. This PR gets rid of this check.It's a bit odd that this failure hasn't shown up before (i.e. outside of the multi-project test suite), but I suspect it's related to the race condition we're seeing here - the MP test suite is likely a bit slower, making it slightly more likely to occur, perhaps.
Resolves #124575