Add HTTP transport startup hook #130812
Merged
Add HTTP transport startup hook #130812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a `startInternal()` method to `AbstractHttpServerTransport` and makes `doStart()` a final method so that we can customize the startup behaviour of the HTTP transport in a follow-up without needing cooperation from subclasses. Relates ES-12223
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
elasticsearchmachine
added
the
Team:Distributed Coordination
Contributor
There only 2 production classes in transport and security. Do we need this "flexibility"? |
Contributor
Author
|
This is just pulled out of another PR to reduce noise. Yes, I'd rather we did this. |
mhl-b
approved these changes
Jul 8, 2025
DaveCTurner
added
the
auto-merge-without-approval
Contributor
Author
|
There's a little more detail in ES-12223 |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
This commit introduces a `startInternal()` method to `AbstractHttpServerTransport` and makes `doStart()` a final method so that we can customize the startup behaviour of the HTTP transport in a follow-up without needing cooperation from subclasses. Relates ES-12223
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
This commit introduces a `startInternal()` method to `AbstractHttpServerTransport` and makes `doStart()` a final method so that we can customize the startup behaviour of the HTTP transport in a follow-up without needing cooperation from subclasses. Relates ES-12223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a
startInternal()method toAbstractHttpServerTransportand makesdoStart()a final method sothat we can customize the startup behaviour of the HTTP transport in a
follow-up without needing cooperation from subclasses.
Relates ES-12223