Skip to content

Add HTTP transport startup hook #130812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2025
Merged

Add HTTP transport startup hook #130812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1912642
Add HTTP transport startup hook
DaveCTurner Jul 8, 2025
4dc3f2b
Merge branch 'main' into 2025/07/08/http-transport-lifecycle
DaveCTurner Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ansport-netty4/src/main/java/org/elasticsearch/http/netty4/Netty4HttpServerTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ public Settings settings() {
}

@Override
protected void doStart() {
protected void startInternal() {
boolean success = false;
try {
sharedGroup = sharedGroupFactory.getHttpGroup();
Expand Down
9 changes: 8 additions & 1 deletion server/src/main/java/org/elasticsearch/http/AbstractHttpServerTransport.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,13 @@ private TransportAddress bindAddress(final InetAddress hostAddress) {

protected abstract HttpServerChannel bind(InetSocketAddress hostAddress) throws Exception;

@Override
protected final void doStart() {
startInternal();
}

protected abstract void startInternal();

/**
* Gracefully shut down. If {@link HttpTransportSettings#SETTING_HTTP_SERVER_SHUTDOWN_GRACE_PERIOD} is zero, the default, then
* forcefully close all open connections immediately.
Expand All @@ -251,7 +258,7 @@ private TransportAddress bindAddress(final InetAddress hostAddress) {
* </ol>
*/
@Override
protected void doStop() {
protected final void doStop() {
synchronized (httpServerChannels) {
if (httpServerChannels.isEmpty() == false) {
try {
Expand Down
38 changes: 12 additions & 26 deletions server/src/test/java/org/elasticsearch/http/AbstractHttpServerTransportTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,14 +211,10 @@ protected HttpServerChannel bind(InetSocketAddress hostAddress) {
}

@Override
protected void doStart() {

}
protected void startInternal() {}

@Override
protected void stopInternal() {

}
protected void stopInternal() {}

@Override
public HttpStats stats() {
Expand Down Expand Up @@ -295,14 +291,10 @@ protected HttpServerChannel bind(InetSocketAddress hostAddress) {
}

@Override
protected void doStart() {

}
protected void startInternal() {}

@Override
protected void stopInternal() {

}
protected void stopInternal() {}

@Override
public HttpStats stats() {
Expand Down Expand Up @@ -385,7 +377,7 @@ protected HttpServerChannel bind(InetSocketAddress hostAddress) {
}

@Override
protected void doStart() {}
protected void startInternal() {}

@Override
protected void stopInternal() {}
Expand Down Expand Up @@ -516,7 +508,7 @@ protected HttpServerChannel bind(InetSocketAddress hostAddress) {
}

@Override
protected void doStart() {}
protected void startInternal() {}

@Override
protected void stopInternal() {}
Expand Down Expand Up @@ -567,9 +559,7 @@ protected HttpServerChannel bind(InetSocketAddress hostAddress) {
}

@Override
protected void doStart() {

}
protected void startInternal() {}

@Override
protected void stopInternal() {
Expand Down Expand Up @@ -710,14 +700,10 @@ protected HttpServerChannel bind(InetSocketAddress hostAddress) {
}

@Override
protected void doStart() {

}
protected void startInternal() {}

@Override
protected void stopInternal() {

}
protected void stopInternal() {}

@Override
public HttpStats stats() {
Expand Down Expand Up @@ -774,7 +760,7 @@ protected HttpServerChannel bind(InetSocketAddress hostAddress) {
}

@Override
protected void doStart() {}
protected void startInternal() {}

@Override
protected void stopInternal() {}
Expand Down Expand Up @@ -856,7 +842,7 @@ protected HttpServerChannel bind(InetSocketAddress hostAddress) {
}

@Override
protected void doStart() {}
protected void startInternal() {}

@Override
protected void stopInternal() {}
Expand Down Expand Up @@ -1226,7 +1212,7 @@ protected HttpServerChannel bind(InetSocketAddress hostAddress) {
}

@Override
protected void doStart() {
protected void startInternal() {
bindServer();
}

Expand Down