-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix IllegalStateException when query match_only_text field with non keyword field type as parent #130845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… instead of interacting with doc values api directly. This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
not-napoleon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. The test covers the scenario we're concerned about, and the solution makes sense.
jordan-powers
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
… instead of interacting with doc values api directly. (#130854) This pulls #130845 into the serverless fix branch for patch deployment. Original description: Change match_only_text's value fetcher to use SortedBinaryDocValues instead of interacting with doc values api directly. This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings. Co-authored-by: Martijn van Groningen <[email protected]>
|
The serverless check failure looks unrelated: |
💔 Backport failedYou can use sqren/backport to manually backport by running |
… instead of interacting with doc values api directly. (elastic#130854) This pulls elastic#130845 into the serverless fix branch for patch deployment. Original description: Change match_only_text's value fetcher to use SortedBinaryDocValues instead of interacting with doc values api directly. This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings. Co-authored-by: Martijn van Groningen <[email protected]>
… instead of interacting with doc values api directly. (elastic#130854) This pulls elastic#130845 into the serverless fix branch for patch deployment. Original description: Change match_only_text's value fetcher to use SortedBinaryDocValues instead of interacting with doc values api directly. This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings. Co-authored-by: Martijn van Groningen <[email protected]>
… instead of interacting with doc values api directly. (#130895) Backporting #130854 to 9.1 branch. This pulls #130845 into the serverless fix branch for patch deployment. Original description: Change match_only_text's value fetcher to use SortedBinaryDocValues instead of interacting with doc values api directly. This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings. Co-authored-by: Mark Tozzi <[email protected]>
… instead of interacting with doc values api directly. (#130896) Backporting #130854 to 8.19 branch. This pulls #130845 into the serverless fix branch for patch deployment. Original description: Change match_only_text's value fetcher to use SortedBinaryDocValues instead of interacting with doc values api directly. This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings. Co-authored-by: Mark Tozzi <[email protected]>
… instead of interacting with doc values api directly. (elastic#130845) This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.
… instead of interacting with doc values api directly. (elastic#130845) This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.
… instead of interacting with doc values api directly. (elastic#130845) This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.
Change match_only_text's value fetcher to use
SortedBinaryDocValuesinstead of interacting with doc values api directly.This way, via field data abstraction, the right doc values type is used, and the right conversions happen. Values of all field types will get converted to strings.
Error that this PR is addressing:
(marking as non-issue, given that this is a bug in unreleased version of ES)