Improve newTraceContext to only modify the current thread context if a trace context exists. #130989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a trace context exists. Otherwise, this will behave exactly as #newStoredContextPreservingResponseHeaders. Relates to #ES-10969
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
added
Team:Core/Infra
mosche
added
the
auto-merge-without-approval
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…a trace context exists. (elastic#130989) Improve newTraceContext to only modify the current thread context if a trace context exists. Otherwise, `newTraceContext` will behave exactly as #newStoredContextPreservingResponseHeaders as there's no reason to cleanup / move tracing headers. Relates to #ES-10969
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
…a trace context exists. (elastic#130989) Improve newTraceContext to only modify the current thread context if a trace context exists. Otherwise, `newTraceContext` will behave exactly as #newStoredContextPreservingResponseHeaders as there's no reason to cleanup / move tracing headers. Relates to #ES-10969
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve newTraceContext to only modify the current thread context if a trace context exists.
Otherwise,
newTraceContextwill behave exactly as #newStoredContextPreservingResponseHeaders as there's no reason to cleanup / move tracing headers.Relates to #ES-10969