Add fetchRange and fetchRegion to SharedBlobCacheService #131000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds two new methods to SharedBlobCacheService, fetchRange and fetchRegion. This new methods provide the same functionality as their maybe version, but the main difference is that they take a new boolean parameter (force) that allows the caller to specify if fetching the range/region should force an eviction if there are no free regions available.
fcofdez
added
>non-issue
Team:Distributed Indexing
Collaborator
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
andreidan
approved these changes
Jul 10, 2025
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
LGTM, thanks Francisco
| * </p> | ||
| * <p> | ||
| * This method returns as soon as the download tasks are instantiated, but the tasks themselves | ||
| * are run on the bulk executor. |
Contributor
There was a problem hiding this comment.
Suggested change
| * are run on the bulk executor. | |
| * are run on the fetch executor. |
elasticsearchmachine
added
the
serverless-linked
Contributor
|
Hi, due to workload this week, I might get to this next week. Feel free to replace me if need-be, else I'll review as soon as possible. |
Contributor
Author
Thanks for the heads up @kingherc. I'm going to merge this PR once CI is green so we can experiment on QA next week. But I'll appreciate your review once you have the bandwidth and I'll tackle any comments you may have. |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
) This commit adds two new methods to SharedBlobCacheService, fetchRange and fetchRegion. This new methods provide the same functionality as their maybe version, but the main difference is that they take a new boolean parameter (force) that allows the caller to specify if fetching the range/region should force an eviction if there are no free regions available.
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 17, 2025
) This commit adds two new methods to SharedBlobCacheService, fetchRange and fetchRegion. This new methods provide the same functionality as their maybe version, but the main difference is that they take a new boolean parameter (force) that allows the caller to specify if fetching the range/region should force an eviction if there are no free regions available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two new methods to SharedBlobCacheService, fetchRange and fetchRegion.
This new methods provide the same functionality as their maybe version, but the main difference
is that they take a new boolean parameter (force) that allows the caller to specify if fetching the
range/region should force an eviction if there are no free regions available.
It also removes the unused method maybeFetchFullEntry.