From 7a78921b3e8bc484bbb1c200facbe1246139e982 Mon Sep 17 00:00:00 2001 From: Luigi Dell'Aquila Date: Thu, 10 Jul 2025 15:22:42 +0200 Subject: [PATCH 1/4] ES|QL: Add breaking change note for brackets in index names --- docs/changelog/130427.yaml | 26 +++++++++++++++++++++++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/docs/changelog/130427.yaml b/docs/changelog/130427.yaml index 4666cf0987cda..bdcdc4f99ea2b 100644 --- a/docs/changelog/130427.yaml +++ b/docs/changelog/130427.yaml @@ -1,5 +1,25 @@ pr: 130427 -summary: Disallow brackets in unquoted index pattersn +summary: Disallow brackets in unquoted index patterns area: ES|QL -type: bug -issues: [] +type: breaking +issues: + - 130378 +breaking: + title: Unquoted index patterns do not allow `(` and `)` characters + area: ES|QL + details: >- + So far, ES|QL accepted unquoted index patterns containing brackets, eg. + + ``` + FROM index(1) | ENRICH policy(2) + ``` + + This can potentially conflict with subquery syntax, that uses brackets as a delimiter. + From now on, using brackets is only allowed in quoted index patterns, ie. the query above is no longer valid, + while the following is valid + + ``` + FROM "index(1)" | ENRICH "policy(2)" + ``` + impact: "It impacts all the queries that contain brackets in index names or policy names, ie. in FROM, ENRICH and LOOKUP JOIN commands" + notable: false From 582612d85219c1f5594e60281e140e226f5e4307 Mon Sep 17 00:00:00 2001 From: Luigi Dell'Aquila Date: Thu, 10 Jul 2025 15:39:04 +0200 Subject: [PATCH 2/4] No triple backticks --- docs/changelog/130427.yaml | 13 +++---------- 1 file changed, 3 insertions(+), 10 deletions(-) diff --git a/docs/changelog/130427.yaml b/docs/changelog/130427.yaml index bdcdc4f99ea2b..d178eff0f8369 100644 --- a/docs/changelog/130427.yaml +++ b/docs/changelog/130427.yaml @@ -8,18 +8,11 @@ breaking: title: Unquoted index patterns do not allow `(` and `)` characters area: ES|QL details: >- - So far, ES|QL accepted unquoted index patterns containing brackets, eg. - - ``` - FROM index(1) | ENRICH policy(2) - ``` + So far, ES|QL accepted unquoted index patterns containing brackets, eg. `FROM index(1) | ENRICH policy(2)` This can potentially conflict with subquery syntax, that uses brackets as a delimiter. - From now on, using brackets is only allowed in quoted index patterns, ie. the query above is no longer valid, - while the following is valid - ``` - FROM "index(1)" | ENRICH "policy(2)" - ``` + From now on, using brackets is only allowed in quoted index patterns, ie. the query above is no longer valid, + while the following is valid: `FROM "index(1)" | ENRICH "policy(2)"` impact: "It impacts all the queries that contain brackets in index names or policy names, ie. in FROM, ENRICH and LOOKUP JOIN commands" notable: false From 2ba48ed647b89fb545e129e84e5009c3d1e518da Mon Sep 17 00:00:00 2001 From: Luigi Dell'Aquila Date: Thu, 10 Jul 2025 19:26:01 +0200 Subject: [PATCH 3/4] Update docs/changelog/130427.yaml Co-authored-by: Liam Thompson --- docs/changelog/130427.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/changelog/130427.yaml b/docs/changelog/130427.yaml index d178eff0f8369..a622da06d4577 100644 --- a/docs/changelog/130427.yaml +++ b/docs/changelog/130427.yaml @@ -14,5 +14,5 @@ breaking: From now on, using brackets is only allowed in quoted index patterns, ie. the query above is no longer valid, while the following is valid: `FROM "index(1)" | ENRICH "policy(2)"` - impact: "It impacts all the queries that contain brackets in index names or policy names, ie. in FROM, ENRICH and LOOKUP JOIN commands" + impact: "This affects existing queries containing brackets in index or policy names, i.e. in FROM, ENRICH, and LOOKUP JOIN commands." notable: false From 79515a9547dd6dfc6a6e92e62d5ad3eb379f7339 Mon Sep 17 00:00:00 2001 From: Luigi Dell'Aquila Date: Thu, 10 Jul 2025 19:26:44 +0200 Subject: [PATCH 4/4] Update docs/changelog/130427.yaml Co-authored-by: Liam Thompson --- docs/changelog/130427.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/docs/changelog/130427.yaml b/docs/changelog/130427.yaml index a622da06d4577..1727a8d2c4f27 100644 --- a/docs/changelog/130427.yaml +++ b/docs/changelog/130427.yaml @@ -8,11 +8,10 @@ breaking: title: Unquoted index patterns do not allow `(` and `)` characters area: ES|QL details: >- - So far, ES|QL accepted unquoted index patterns containing brackets, eg. `FROM index(1) | ENRICH policy(2)` + Previously, ES|QL accepted unquoted index patterns containing brackets, such as `FROM index(1) | ENRICH policy(2)`. - This can potentially conflict with subquery syntax, that uses brackets as a delimiter. + This query syntax is no longer valid because it could conflict with subquery syntax, where brackets are used as delimiters. - From now on, using brackets is only allowed in quoted index patterns, ie. the query above is no longer valid, - while the following is valid: `FROM "index(1)" | ENRICH "policy(2)"` + Brackets are now only allowed in quoted index patterns. For example: `FROM "index(1)" | ENRICH "policy(2)"`. impact: "This affects existing queries containing brackets in index or policy names, i.e. in FROM, ENRICH, and LOOKUP JOIN commands." notable: false