Skip to content

Speed up reading multivalued keywords #131061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 15, 2025
Merged

Speed up reading multivalued keywords #131061

merged 7 commits into from
Jul 15, 2025

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 11, 2025 •
edited
Loading

This change speeds up reading multi-valued keyword fields by leveraging ordinals.

Before:

Benchmark                              (layout)          (name)  Mode  Cnt     Score    Error  Units
ValuesSourceReaderBenchmark.benchmark  in_order      keyword_mv  avgt    7   318.332 ±  1.660  ns/op

After:

Benchmark                              (layout)          (name)  Mode  Cnt     Score    Error  Units
ValuesSourceReaderBenchmark.benchmark  in_order      keyword_mv  avgt    7    96.659 ±  0.932  ns/op

@dnhatn dnhatn force-pushed the read-ordinals-set branch from c0d5e5d to 3b2e5db Compare July 11, 2025 03:11
@dnhatn dnhatn force-pushed the read-ordinals-set branch from bcbf39d to 9aff023 Compare July 11, 2025 04:58
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 11, 2025

Hi @dnhatn, I've created a changelog YAML for you.

@dnhatn dnhatn requested review from Copilot and nik9000 and removed request for Copilot July 11, 2025 05:08
@dnhatn dnhatn marked this pull request as ready for review July 11, 2025 05:09
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 11, 2025
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jul 11, 2025

Pinging @elastic/es-analytical-engine (Team:Analytics)

This comment was marked as off-topic.

Sign in to view

@dnhatn
Copy link
Member Author

dnhatn commented Jul 15, 2025

Thanks Nik!

@dnhatn dnhatn merged commit c2fa78f into elastic:main Jul 15, 2025
33 checks passed
@dnhatn dnhatn deleted the read-ordinals-set branch July 15, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@nik9000 nik9000 nik9000 approved these changes

Assignees

No one assigned

Labels

:Analytics/ES|QL AKA ESQL >enhancement Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dnhatn @elasticsearchmachine @nik9000