From b827109f22a5ba64d105a6d44e04d9be6c72c02c Mon Sep 17 00:00:00 2001 From: Iraklis Psaroudakis Date: Tue, 15 Jul 2025 17:55:30 +0300 Subject: [PATCH] Fix concurrent list in merge test (#131186) Relates #131165 --- .../ThreadPoolMergeExecutorServiceDiskSpaceTests.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeExecutorServiceDiskSpaceTests.java b/server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeExecutorServiceDiskSpaceTests.java index 9dd86a5b00e74..85169ac1330e6 100644 --- a/server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeExecutorServiceDiskSpaceTests.java +++ b/server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeExecutorServiceDiskSpaceTests.java @@ -14,6 +14,7 @@ import org.elasticsearch.common.settings.ClusterSettings; import org.elasticsearch.common.settings.Settings; import org.elasticsearch.common.unit.ByteSizeValue; +import org.elasticsearch.common.util.concurrent.ConcurrentCollections; import org.elasticsearch.common.util.concurrent.EsExecutors; import org.elasticsearch.core.PathUtils; import org.elasticsearch.core.PathUtilsForTesting; @@ -40,6 +41,7 @@ import java.util.IdentityHashMap; import java.util.LinkedHashSet; import java.util.List; +import java.util.Set; import java.util.concurrent.CountDownLatch; import java.util.concurrent.Executor; import java.util.concurrent.TimeUnit; @@ -897,8 +899,8 @@ public void testEnqueuedMergeTasksAreUnblockedWhenEstimatedMergeSizeChanges() th assertBusy( () -> assertThat(threadPoolMergeExecutorService.getDiskSpaceAvailableForNewMergeTasks(), is(expectedAvailableBudget.get())) ); - List tasksRunList = new ArrayList<>(); - List tasksAbortList = new ArrayList<>(); + Set tasksRunList = ConcurrentCollections.newConcurrentSet(); + Set tasksAbortList = ConcurrentCollections.newConcurrentSet(); int submittedMergesCount = randomIntBetween(1, 5); long[] mergeSizeEstimates = new long[submittedMergesCount]; for (int i = 0; i < submittedMergesCount; i++) {