Skip to content

Conversation

Mikep86
Copy link
Contributor

@Mikep86 Mikep86 commented Jul 31, 2025

The semantic_text exists query tests didn't provide good coverage for when a subset of the documents in an index had a value for the field. I added some additional test cases to cover this.

@Mikep86 Mikep86 requested review from a team and carlosdelest July 31, 2025 16:22
@Mikep86 Mikep86 added >test Issues or PRs that are addressing/adding tests auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team v8.19.1 v9.0.5 v8.17.10 v8.18.5 labels Jul 31, 2025
@elasticsearchmachine elasticsearchmachine added Team:SearchOrg Meta label for the Search Org (Enterprise Search) v9.2.0 Team:Search - Relevance The Search organization Search Relevance team labels Jul 31, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-eng (Team:SearchOrg)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/search-relevance (Team:Search - Relevance)

Copy link
Contributor

@markjhoy markjhoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@Mikep86
Copy link
Contributor Author

Mikep86 commented Jul 31, 2025

@elasticmachine update branch

@Mikep86
Copy link
Contributor Author

Mikep86 commented Aug 1, 2025

@elasticmachine update branch

@Mikep86 Mikep86 merged commit 71bd083 into elastic:main Aug 1, 2025
33 checks passed
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Aug 1, 2025
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Aug 1, 2025
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.19
9.0
8.17
8.18

Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Aug 1, 2025
Mikep86 added a commit to Mikep86/elasticsearch that referenced this pull request Aug 1, 2025
elasticsearchmachine pushed a commit that referenced this pull request Aug 1, 2025
szybia added a commit to szybia/elasticsearch that referenced this pull request Aug 15, 2025
* upstream/main: (822 commits)
  Improve Semantic Text Exists Query Tests (elastic#132283)
  Make hierarchical k-means over centroids cheaper (elastic#132316)
  Remove unnecessary listener.delegateFailure in IndexShard#ensureMutable (elastic#132294)
  Add missing release note (elastic#132319)
  Unmute elastic#131803 (elastic#132295)
  Include bytes for live docs in ShardFieldStats (elastic#132232)
  Fix default missing index sort value of data_nanos pre 7.14 (elastic#132162)
  [DiskBBQ] Quantize centroids using 7 bits instead of 4 bits (elastic#132261)
  Use panamized version for windows in Int7VectorScorer (elastic#132311)
  Mute org.elasticsearch.xpack.ml.integration.AutodetectMemoryLimitIT testTooManyByAndOverFields elastic#132310
  Mute org.elasticsearch.xpack.ml.integration.AutodetectMemoryLimitIT testManyDistinctOverFields elastic#132308
  Update 8.17 version to 8.17.10 (elastic#132303)
  Mute org.elasticsearch.datastreams.DataStreamsClientYamlTestSuiteIT test {p0=data_stream/10_basic/Create hidden data stream with match all template} elastic#132298
  Add random queries to logsdb data generation tests (elastic#132109)
  ES|QL Inference runner refactoring (elastic#131986)
  Add basic example to linear-retriever.md (elastic#132196)
  Refactor RemoteClusterService to be multi-project aware (elastic#131894)
  ESQL: Mark csv-spec tests (elastic#132098)
  Mute org.elasticsearch.common.logging.JULBridgeTests testThrowable elastic#132280
  Bump versions after 8.19.0 release
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :SearchOrg/Relevance Label for the Search (solution/org) Relevance team Team:Search - Relevance The Search organization Search Relevance team Team:SearchOrg Meta label for the Search Org (Enterprise Search) >test Issues or PRs that are addressing/adding tests v8.17.10 v8.18.5 v8.19.1 v9.0.5 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants