From 27ee9f0b2391978cd65910cc41820c155ffd4bf9 Mon Sep 17 00:00:00 2001 From: Alexander Spies Date: Mon, 4 Aug 2025 16:25:43 +0200 Subject: [PATCH 1/2] Update javadoc for Function.java --- .../xpack/esql/core/expression/function/Function.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java b/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java index cad5c631088f2..60192d3fe2de5 100644 --- a/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java +++ b/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java @@ -17,8 +17,8 @@ import java.util.StringJoiner; /** - * Any SQL expression with parentheses, like {@code MAX()}, or {@code ABS()}. A - * function is always a {@code NamedExpression}. + * Any ESQL function; generally this is translated into a computation to be evaluated on arguments, including scalar functions (e.g. in + * {@code EVAL}) or aggregations ({@code STATS}). */ public abstract class Function extends Expression { From 87b17383ccc65a3d377607773db4460c1e22e719 Mon Sep 17 00:00:00 2001 From: Alexander Spies Date: Tue, 5 Aug 2025 17:11:24 +0200 Subject: [PATCH 2/2] Update x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java Co-authored-by: Bogdan Pintea --- .../xpack/esql/core/expression/function/Function.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java b/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java index 60192d3fe2de5..9d176b9f8c6d9 100644 --- a/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java +++ b/x-pack/plugin/esql-core/src/main/java/org/elasticsearch/xpack/esql/core/expression/function/Function.java @@ -18,7 +18,7 @@ /** * Any ESQL function; generally this is translated into a computation to be evaluated on arguments, including scalar functions (e.g. in - * {@code EVAL}) or aggregations ({@code STATS}). + * {@code EVAL}) or aggregation functions ({@code STATS}). */ public abstract class Function extends Expression {