ESQL - Fix knn test on multiple shards #132753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
added
>test
elasticsearchmachine
added
the
serverless-linked
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
carlosdelest
requested review from
ChrisHegarty,
afoucret,
ioanatia,
kderusso,
svilen-mihaylov-elastic and
tteofili
kderusso
approved these changes
Aug 13, 2025
| from colors | ||
| | where knn(rgb_vector, [120,180,0], 10) and (match(color, "olive") or match(color, "green")) | ||
| | sort color asc | ||
| | keep color |
Member
There was a problem hiding this comment.
We could probably still keep the rgb_vector data for this test even if we're no longer sorting on score?
Member
Author
There was a problem hiding this comment.
We could - however, I don't see the point as we don't need to check scores here, so it doesn't serve any debugging purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test fixes potential scoring issues when using multiple shards, for example on serverless.