Skip to content

Conversation

@limotova
Copy link
Contributor

@limotova limotova commented Aug 13, 2025

This PR adds CSV tests for avg-, count-, count-distinct-, first-, last-, and sum-over-time tests, and adds a few more fields to the k8s/-downsampled data sets (4 geospatial types used in the count-over-time tests)

@limotova limotova force-pushed the more-csv-tests branch 3 times, most recently from c9cf85d to 16aee59 Compare August 19, 2025 00:46
@limotova limotova added >test Issues or PRs that are addressing/adding tests :StorageEngine/TSDB You know, for Metrics :StorageEngine/ES|QL Timeseries / metrics / logsdb capabilities in ES|QL labels Aug 19, 2025
@limotova limotova marked this pull request as ready for review August 19, 2025 07:30
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@limotova
Copy link
Contributor Author

I decided to add the new tests into their own files for easier organizing in this PR, should I do the same for the existing min/max-over-time tests?

@kkrik-es
Copy link
Contributor

I decided to add the new tests into their own files for easier organizing in this PR, should I do the same for the existing min/max-over-time tests?

++

Copy link
Contributor

@kkrik-es kkrik-es left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Thanks Larisa!

@limotova limotova merged commit 74d219d into elastic:main Aug 19, 2025
34 checks passed
@limotova limotova deleted the more-csv-tests branch August 19, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:StorageEngine/ES|QL Timeseries / metrics / logsdb capabilities in ES|QL :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants