-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[ES|QL] Add more timeseries CSV tests #132873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c9cf85d to
16aee59
Compare
16aee59 to
ce99a90
Compare
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
I decided to add the new tests into their own files for easier organizing in this PR, should I do the same for the existing min/max-over-time tests? |
++ |
kkrik-es
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done.
dnhatn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Thanks Larisa!
This PR adds CSV tests for avg-, count-, count-distinct-, first-, last-, and sum-over-time tests, and adds a few more fields to the k8s/-downsampled data sets (4 geospatial types used in the count-over-time tests)