Slightly improve TrackingPostingsInMemoryBytesCodec #132905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and use int hashset to keep track of seen fields.
martijnvg
changed the title
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
jordan-powers
approved these changes
Aug 14, 2025
Contributor
jordan-powers
left a comment
jordan-powers
left a comment
There was a problem hiding this comment.
LGTM, thanks Martijn!
Comment on lines
112
to
114
| // As far as I know only when bloom filter for _id filter gets written this method gets invoked twice for the same field. | ||
| // So maybe we can get rid of the seenFields here? And just keep track of whether _id field has been seen? | ||
| return terms; |
Contributor
There was a problem hiding this comment.
I think it's difficult to guarantee that we'll only ever invoke this method twice for _id fields. I think only checking the _id field would potentially open us up to some subtle bugs in the future.
Comment on lines
73
to
75
| // Alternatively, we can consider using a FixedBitSet here and size to max(fieldNumber). T | ||
| // his should be faster without worrying too much about memory usage. | ||
| this.seenFields = new IntHashSet(state.fieldInfos.size()); |
Contributor
There was a problem hiding this comment.
I agree it's probably better to prioritize speed over memory efficiency here.
javanna
pushed a commit
to javanna/elasticsearch
that referenced
this pull request
Aug 18, 2025
Replace int hashmap by a counter in TrackingPostingsInMemoryBytesCodec and use int hashset to keep track of seen fields.
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 18, 2025
Replace int hashmap by a counter in TrackingPostingsInMemoryBytesCodec and use int hashset to keep track of seen fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace int hashmap by a counter in TrackingPostingsInMemoryBytesCodec and use int hashset to keep track of seen fields.