ESQL - Allow null values in vector similarity functions #132919
Merged
+148
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosdelest
added
>non-issue
:Analytics/ES|QL
…larity-null-management' into non-issue/esql-vector-similarity-null-management
carlosdelest
commented
Aug 14, 2025
| // end::vector-dot-product-result[] | ||
| ; | ||
|
|
||
| similarityAsPartOfExpression |
Member
Author
There was a problem hiding this comment.
Unrelated changes - indenting was wrong so I fixed it on all test files
svilen-mihaylov-elastic
approved these changes
Aug 14, 2025
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
Collaborator
|
Pinging @elastic/search-eng (Team:SearchOrg) |
Collaborator
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
carlosdelest
requested review from
ChrisHegarty,
afoucret,
ioanatia,
kderusso and
tteofili
…-similarity-null-management # Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/action/EsqlCapabilities.java
joshua-adams-1
pushed a commit
to joshua-adams-1/elasticsearch
that referenced
this pull request
Aug 15, 2025
* Allow null values and return null as result * Fix indentation * [CI] Auto commit changes from spotless * Remove unnecessary return * Fix verifier tests * Fix bwc tests introducing capability --------- Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vector similarity functions did not allow null as a parameter, and returned 0.0 when comparing null vectors. This PR fixes that: