Implement docIDRunEnd() on ES819TSDBDocValuesProducer #132939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method allows consumers to quickly check if a DocIdSetIterator matches a large run of documents; it was missing from our custom Codec DocValues implementations.
|
💚 CLA has been signed |
elasticsearchmachine
added
needs:triage
romseygeek
added
:StorageEngine/Codec
and removed
needs:triage
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Contributor
Author
|
@elasticmachine test this please |
Member
|
cla/check |
martijnvg
approved these changes
Aug 15, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM
Somehow changelog entry wasn't added automatically. Not sure why.
Maybe label as non-issue? (then change log entry is not required)
Because this change comes with Lucene 10.3, currently stock doc values don't have still either. We caught up with this change in Lucene on time.
Contributor
Author
|
@elasticmachine test this please |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method allows consumers to quickly check if a DocIdSetIterator matches a
large run of documents; it was missing from our custom Codec DocValues implementations.