Skip to content

Conversation

@masseyke
Copy link
Member

This adds the ability to deserialize StreamsMetadata from xcontent. Since it is stored as xcontent in the cluster state, we were unable to read the existing cluster state on node restarts or snapshot restores.
Closes #132468

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Aug 14, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this Keith

@masseyke masseyke added auto-backport Automatically create backport pull requests when merged v9.1.3 v8.19.3 labels Aug 14, 2025
Copy link
Contributor

@seanzatzdev seanzatzdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@masseyke masseyke merged commit d33dceb into elastic:main Aug 15, 2025
32 of 33 checks passed
@masseyke masseyke deleted the streams-metadata-serialization-fix branch August 15, 2025 13:43
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
9.1
8.19 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 132953

@masseyke
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.19

Questions ?

Please refer to the Backport tool documentation

masseyke added a commit to masseyke/elasticsearch that referenced this pull request Aug 15, 2025
(cherry picked from commit d33dceb)

# Conflicts:
#	server/src/main/java/org/elasticsearch/cluster/metadata/StreamsMetadata.java
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Aug 18, 2025
elasticsearchmachine pushed a commit that referenced this pull request Aug 18, 2025
* Fixing StreamsMetadata xcontent serialization (#132953)

(cherry picked from commit d33dceb)

# Conflicts:
#	server/src/main/java/org/elasticsearch/cluster/metadata/StreamsMetadata.java

* removing reference to project

* [CI] Auto commit changes from spotless

---------

Co-authored-by: elasticsearchmachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Data Management/Data streams Data streams and their lifecycles >non-issue Team:Data Management Meta label for data/management team v8.19.3 v9.1.3 v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GET _streams/status state is not included in snapshot

5 participants