Skip to content

Expose APIs needed by flush during translog replay #132960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2025
Merged

Expose APIs needed by flush during translog replay #132960

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f02f4f
Expose APIs needed by flush during translog replay
lkts Aug 14, 2025
ebf00a2
Address feedback
lkts Aug 15, 2025
8b30437
Merge branch 'main' into allow_flush_during_translog_replay
lkts Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,6 +620,10 @@ public void skipTranslogRecovery() {
pendingTranslogRecovery.set(false); // we are good - now we can commit
}

public boolean pendingTranslogRecovery() {
Copy link
Contributor

@henningandersen henningandersen Aug 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, one change, can we make this protected instead? Looks like it is only used by the subclass so just choosing the least visible option.

return pendingTranslogRecovery.get();
}

private void recoverFromTranslogInternal(
TranslogRecoveryRunner translogRecoveryRunner,
long recoverUpToSeqNo,
Expand Down Expand Up @@ -3133,7 +3137,7 @@ protected Map<String, String> getCommitExtraUserData(final long localCheckpoint)
return Collections.emptyMap();
}

final void ensureCanFlush() {
protected void ensureCanFlush() {
// translog recovery happens after the engine is fully constructed.
// If we are in this stage we have to prevent flushes from this
// engine otherwise we might loose documents if the flush succeeds
Expand Down