Apply RemoveUnusedImports

[Pankraz76]

enabler for:

• Add rewrite support for RemoveUnusedImports #131611

• Have you signed the contributor license agreement?
• Have you followed the contributor guidelines?
• If submitting code, have you built your formula locally prior to submission with gradle check?
• If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
• If submitting code, have you checked that your submission is for an OS and architecture that we support?
• If you are submitting this code for a class then read our policy for that.

[Pankraz76]

re run actually it will resolve all wildcard imports.

[DaveCTurner]

We already have a rule forbidding unused imports. It seems as if it needs adjusting for these cases (excluding the generated code, we don't care about unused imports there). Definitely no need to take on all the work of adopting another static analysis tool just to do this tho. I'm closing this because I see that you're spamming the same sort of change across several unrelated projects on Github, but if you'd like to combine this change with adjustments to the Spotless config to prevent similar issues in future then please open a fresh PR to do that.

[Pankraz76]

Spotless

can not handle wildcard import, it just a text parser, therefore considerer second class, PMD and rewrite both type aware.

[DaveCTurner]

can not handle wildcard import

Sure, but wildcard imports are forbidden by other rules in this codebase. Clearly those rules aren't being applied everywhere, and we'd welcome a PR from you to fix up this misconfiguration.

[Pankraz76]

Yes, but even if the config is there, how to fix all the wildcards if not with rewrite?

I'm not going to "spend" time on this. Of course, I could run the plugin locally and commit the changes, but that's considered cheating—taking the changes, but not the plugin doing so.

Im only doing it the right way, in order not to waste our time.

As its not only about wildcards assuming security fixes done by file recipe are something important for elastic as well:

• Apply security fixes featuring refasterrules.FileRulesRecipes keycloak/keycloak#41887
• Apply security fixes featuring refasterrules.FileRulesRecipes jenkinsci/jenkins#10961
• https://error-prone.picnic.tech/refasterrules/FileRules/

[Pankraz76]

Assuming Spotless is broken because the convention-over-configuration principle wasn't properly implemented.

[DaveCTurner]

No need to assume anything - if you'd like to open a PR to fix the Spotless config then that'd be very welcome, but if not then that's also fine. Either way, there's nothing more to discuss here so I'm locking this conversation.