-
Notifications
You must be signed in to change notification settings - Fork 25.7k
Speed up loading dense singleton keyword fields #132994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up loading dense singleton keyword fields #132994
Conversation
| return null; | ||
| } | ||
| try (var builder = factory.singletonOrdinalsBuilder(this, docs.count() - offset, true)) { | ||
| BlockLoader.SingletonLongBuilder delegate = new SingletonLongToSingletonOrdinalDelegate(builder); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any subclasses of BlockLoader.Block aren't accessible from server. So instead of consuming the block that denseOrds would produce, I have a delegate builder that translates the long values to int values (given that singleton ordinals works with int[]).
… look ahead logic
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
I see the following results when running this query locally: When running the following request to get profiling: I see the following results: |
|
The following query: |
dnhatn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Martijn!
|
Note that serverless check failed because of the following OOME: This is unrelated to this change. But caused all the |
With this change both sorted set and number doc values use the same bulk loading for values/ordinals. This PR supersedes (elastic#132715) that also sped up loading dense singleton keyword fields, but duplicated the bulk encoding logic.
With this change both sorted set and number doc values use the same bulk loading for values/ordinals.
This PR supersedes (#132715) that also sped up loading dense singleton keyword fields, but duplicated the bulk encoding logic.