Skip to content

Conversation

@Pankraz76
Copy link

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@Pankraz76
Copy link
Author

enabler for:

@elasticsearchmachine elasticsearchmachine added v9.2.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Aug 16, 2025
@Pankraz76
Copy link
Author

execution gradle --write-verification-metadata sha256 gives me this change.

@breskeby
Copy link
Contributor

This PR does not add any value. Again. Please read our contribution guidelines.

@Pankraz76
Copy link
Author

Pankraz76 commented Aug 16, 2025

Does the command not reproduce this state on your system?

If its not changing then it could be added to the spotlessApply part making sure everything is in sync.

gradle --write-verification-metadata sha256

@breskeby
Copy link
Contributor

Useless change, not adding any value

@breskeby breskeby closed this Aug 16, 2025
@breskeby
Copy link
Contributor

it doesn't matter if it reproduces or not. the whole point of --write-verification-metadata sha256 is to concisly run it when you add a dependency to ensure the checksum are solid. tempering with that as part of the ci pipeline is basically in contrast to the whole idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external-contributor Pull request authored by a developer outside the Elasticsearch team v9.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants