Skip to content

Conversation

@dnhatn
Copy link
Member

@dnhatn dnhatn commented Aug 17, 2025

With #132774, the overhead of running queries with DOC partitioning is small. While we might switch the default data partitioning to DOC for all queries in the future, this PR defaults data partitioning to DOC for time-series queries only to minimize any unexpected impact.

I tested this change with my local benchmark: the response time for avg_avgot_memory_by_host_1h decreased for from 80ms to less than 40ms.

Relates #132774

@dnhatn dnhatn added :StorageEngine/TSDB You know, for Metrics >non-issue labels Aug 17, 2025
@dnhatn dnhatn marked this pull request as ready for review August 17, 2025 07:09
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Aug 18, 2025

Thanks Martijn!

@dnhatn dnhatn merged commit a5c0852 into elastic:main Aug 18, 2025
34 checks passed
@dnhatn dnhatn deleted the default-ts-to-doc-partitioning branch August 18, 2025 02:55
javanna pushed a commit to javanna/elasticsearch that referenced this pull request Aug 18, 2025
…33038)

With elastic#132774, the overhead of running queries with DOC partitioning is 
small. While we might switch the default data partitioning to DOC for
all queries in the future, this PR defaults data partitioning to DOC for
time-series queries only to minimize any unexpected impact.


Relates elastic#132774
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Aug 18, 2025
…33038)

With elastic#132774, the overhead of running queries with DOC partitioning is 
small. While we might switch the default data partitioning to DOC for
all queries in the future, this PR defaults data partitioning to DOC for
time-series queries only to minimize any unexpected impact.


Relates elastic#132774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants